Fix PKGI reconciliation taking old App status during upgrade

[mdzhigarov]

Problem

Fix race condition in PackageInstall reconciler where status was set based on App state before updating the App spec, leading to temporary inconsistencies.

Solution

• Refactored reconcileAppWithPackage to accept a status updater closure
• Status is now set based on the App state AFTER any spec updates
• Eliminates race condition where PackageInstall shows stale status

Changes

• Modified reconcile() method to create status updater closure
• Updated reconcileAppWithPackage() to accept and call the closure with correct App instance
• Added comprehensive tests demonstrating the fix

Testing

• Added Test_StatusUpdaterClosureUsesUpdatedAppState - tests the race condition scenario
• Added Test_StatusUpdaterClosureWithNoAppUpdate - tests non-update scenario
• All existing tests continue to pass

Fixes: (https://vmw-jira.broadcom.net/browse/TNZ-54843)

[praveenrewar]

Thanks for the PR Marin!
(Took a quick peek) This is the fix that I had in my mind as well, I will go through the tests in detail once the checks are green.
I think @cppforlife had some more thoughts regarding this so let's wait for him to add his comments.

[cppforlife]

lgtm from me. @praveenrewar care to take a look?

[praveenrewar]

@mdzhigarov Changes looks good to me apart from the small (optional) nit.
My only concern is that we don't have a proper test for this. It might be tricky to add a test for this but even if we could validate that the change is fixing the issue would be a good to have.