Skip to content

debug: onramp broadcast channels#2455

Merged
broody merged 1 commit intomainfrom
debug-onramp
Feb 27, 2026
Merged

debug: onramp broadcast channels#2455
broody merged 1 commit intomainfrom
debug-onramp

Conversation

@broody
Copy link
Contributor

@broody broody commented Feb 27, 2026

No description provided.

@vercel
Copy link

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Building Building Preview Feb 27, 2026 8:21pm
keychain Building Building Preview Feb 27, 2026 8:21pm
keychain-storybook Building Building Preview Feb 27, 2026 8:21pm

Request Review

@claude
Copy link
Contributor

claude bot commented Feb 27, 2026

Claude finished @broody's task —— View job


Documentation Analysis

Analyzing PR #2455 changes to determine if documentation updates are needed.

Tasks

  • Read changed files to understand modifications
  • Analyze if changes are user-facing or internal
  • Make documentation decision

Analysis Complete

No documentation updates required.

Reasoning:

This PR contains internal debugging changes only:

  1. Added console.log statements throughout both files for debugging BroadcastChannel communication
  2. Changed polling intervals internally (from 1s constant poll to 15s fallback + 1s confirmation poll)
  3. Commented out auto-close behavior (setTimeout(() => window.close(), 1500))

Why these don't need docs:

  • Console logs: Internal debugging instrumentation, not user-facing API
  • Polling interval changes: Implementation detail of how the hook monitors payment status internally. The external API (useCoinbase hook) remains unchanged — same methods, same return values, same behavior from the developer's perspective
  • Auto-close commented out: UI behavior change during development/debugging, not a stable API change

What would require docs:

  • New exported functions or hook methods
  • Changed function signatures or return types
  • New required configuration
  • Changed user-facing behavior (e.g., if polling intervals were exposed as configurable options)

Following the instruction: "DEFAULT TO NO CHANGES. Internal refactors, test changes, CI changes, and dependency bumps need nothing."

--- | Branch: claude/pr-2455-20260227-2032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant