Skip to content

fix: onramp popup polling, retry state, and non-terminal commit errors#2454

Merged
broody merged 1 commit intomainfrom
fix/onramp-popup-improvements
Feb 27, 2026
Merged

fix: onramp popup polling, retry state, and non-terminal commit errors#2454
broody merged 1 commit intomainfrom
fix/onramp-popup-improvements

Conversation

@broody
Copy link
Contributor

@broody broody commented Feb 27, 2026

  • Poll backend at 1s from popup open for immediate status detection
  • Add 15s confirmation timeout when popup signals success
  • Set terminal ref on success signal to prevent popup-closed race
  • Clear failed/error state on retry events in popup (pending_payment_auth, payment_authorized, apple_pay_button_pressed)
  • Treat commit_error as non-terminal (UI falls back to QR code)
  • Animate status bar with slide-down transition instead of shifting iframe
  • Use HeaderInner title/description props to fix text truncation

@vercel
Copy link

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Feb 27, 2026 7:42pm
keychain Ready Ready Preview Feb 27, 2026 7:42pm
keychain-storybook Ready Ready Preview Feb 27, 2026 7:42pm

Request Review

- Poll backend at 1s from popup open for immediate status detection
- Add 15s confirmation timeout when popup signals success
- Set terminal ref on success signal to prevent popup-closed race
- Clear failed/error state on retry events in popup (pending_payment_auth,
  payment_authorized, apple_pay_button_pressed)
- Treat commit_error as non-terminal (UI falls back to QR code)
- Animate status bar with slide-down transition instead of shifting iframe
- Use HeaderInner title/description props to fix text truncation
@claude
Copy link
Contributor

claude bot commented Feb 27, 2026

Claude finished @broody's task —— View job


Documentation Analysis Complete

  • Analyze PR changes to identify user-facing impacts
  • Check existing documentation for Coinbase onramp
  • Determine documentation updates needed

Analysis

Found documentation at docs-repo/src/pages/controller/coinbase-onramp.md. Reviewing PR #2454 changes:

Changes in this PR:

  1. Polling interval: 5s → 1s (internal implementation detail)
  2. Confirmation timeout: Added 15s timeout (internal implementation detail)
  3. commit_error handling: Now non-terminal - UI falls back to QR code (UX improvement)
  4. Retry state: Clear failed/error state on retry events (bug fix)
  5. Animation: Status bar slide-down transition (internal UI)
  6. Text truncation: Fix using HeaderInner props (bug fix)

Decision: No Documentation Updates Required

Per the documentation rules (Rule 1: DEFAULT TO NO CHANGES), these changes do not require documentation updates because:

  1. Internal Implementation Details: The polling interval changes, confirmation timeout, and animation improvements are internal implementation details not exposed to SDK users or documented in the API reference.

  2. Bug Fixes, Not New Features: The changes fix existing behavior (retry state clearing, text truncation) rather than introducing new user-facing features.

  3. Transparent UX Improvements: The commit_error fallback to QR code is a graceful degradation that makes the existing flow more robust. Users already see QR codes as a fallback - this just improves when that fallback is shown. The existing documentation already describes the general flow correctly.

  4. No API Changes: No new methods, parameters, or configuration options were added that users need to know about.

The existing documentation at coinbase-onramp.md accurately describes:

  • The user flow (steps 1-8)
  • Error handling capabilities
  • Payment processing behavior

These internal improvements make that documented flow work more reliably without changing what's visible to end users.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant