Skip to content

fix: remove reopen payment window button#2448

Merged
broody merged 2 commits intomainfrom
fix/remove-reopen-button
Feb 25, 2026
Merged

fix: remove reopen payment window button#2448
broody merged 2 commits intomainfrom
fix/remove-reopen-button

Conversation

@broody
Copy link
Contributor

@broody broody commented Feb 25, 2026

Removes the "REOPEN PAYMENT WINDOW" button and its associated handleRetryPopup logic from the Coinbase checkout screen. Users can navigate back to reinitiate the payment flow instead.

The "TRY AGAIN" button on the failure state now calls handleContinue to reopen the popup.

@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Feb 25, 2026 11:04pm
keychain Ready Ready Preview Feb 25, 2026 11:04pm
keychain-storybook Ready Ready Preview Feb 25, 2026 11:04pm

Request Review

@claude
Copy link
Contributor

claude bot commented Feb 25, 2026

Claude finished @broody's task —— View job


Documentation Analysis Complete

  • Analyze changed files to understand user-facing impact
  • Search docs repository for Coinbase payment documentation
  • Determine if documentation updates are required
  • Final assessment

Analysis Summary

After reviewing the PR changes and the existing Coinbase onramp documentation, I've determined that no documentation updates are required.

Reasoning

  1. Internal UI Refinement: The PR removes a "REOPEN PAYMENT WINDOW" button from the keychain's internal UI. This is an internal implementation detail of how the payment popup is managed, not a change to the Controller SDK API or user-facing functionality.

  2. No Behavioral Change: The payment flow remains the same from a user perspective:

    • Users still select Coinbase onramp as a payment method
    • A popup still opens for payment processing
    • On failure, users can still retry (now via the "TRY AGAIN" button or by navigating back)
    • The existing documentation accurately describes the user experience flow
  3. Debug Logging Only: Most of the diff consists of added console.log statements for debugging postMessage communication. These are developer tools, not user-facing changes.

  4. Documentation Scope: The Coinbase onramp documentation describes the high-level user experience flow (selection, compliance check, cost breakdown, payment processing, etc.). The removal of a specific button in the keychain UI doesn't affect this documented flow.

  5. Adherence to Rules: Following the instruction to "DEFAULT TO NO CHANGES" - this is exactly the type of internal refactor/UI polish that does not warrant documentation updates. The canonical information about Coinbase onramp user experience remains accurate.

Conclusion

The PR is an internal implementation improvement that simplifies the payment retry UX without changing the documented functionality. No updates to the docs repository are needed.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant