fix: add required sandbox and referrerpolicy attrs to coinbase iframe#2447
Merged
fix: add required sandbox and referrerpolicy attrs to coinbase iframe#2447
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
broody
force-pushed
the
fix/coinbase-iframe-attrs
branch
from
1efe447 to
bda46db
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… popup Replace GraphQL polling in the popup with Coinbase's native postMessage events for real-time feedback. Add required iframe sandbox and referrerPolicy attributes. Events handled: - load_success: hide loading spinner when Apple Pay button is ready - load_error: show error with Coinbase's localized message - commit_success: show 'processing' indicator after Apple Pay tap - commit_error: show specific decline/error reasons - cancel: notify user payment was cancelled - polling_success: auto-close popup on confirmed transaction - polling_error: show transaction failure details The keychain-side hook still polls via GraphQL independently.
broody
force-pushed
the
fix/coinbase-iframe-attrs
branch
from
bda46db to
bae0693
Compare
Contributor
|
Claude finished @broody's task —— View job Analysis CompletePR Summary:
Documentation Decision: NO UPDATES NEEDED Reasoning:
DEFAULT TO NO CHANGES applied: Per the documentation rules, internal refactors, security fixes, and implementation details do not require documentation updates unless they change how developers integrate or use the feature. This PR is purely an internal implementation improvement to meet Coinbase's technical requirements and improve the popup's real-time feedback mechanism. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the required
sandbox="allow-scripts allow-same-origin"andreferrerPolicy="no-referrer"attributes to the Coinbase payment iframe in the popup, as required by Coinbase's embed documentation.