feat: replace coinbase popup embed with success redirect page#2446
Closed
feat: replace coinbase popup embed with success redirect page#2446
Conversation
Revert to opening the raw Coinbase paymentLink directly in the popup. Coinbase now includes a redirectUrl pointing to /coinbase/success, which shows a success confirmation and auto-closes the popup. - Remove coinbase-popup.tsx (iframe embed + polling approach) - Add coinbase-success.tsx (simple success page at /coinbase/success) - Revert openPaymentPopup to open paymentLink directly - Keychain still polls order status independently via GraphQL
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the iframe-embed approach in the popup and instead opens the raw Coinbase
paymentLinkdirectly. Coinbase now includes aredirectUrlthat points to/coinbase/successon the keychain, which shows a success confirmation and auto-closes the popup.Changes
coinbase-popup.tsx(iframe embed + in-popup polling)coinbase-success.tsx— simple page at/coinbase/successthat:openPaymentPopupto open the rawpaymentLinkdirectlyFlow
https://x.cartridge.gg/coinbase/success