Skip to content

fix: prefer close over back in iframe header#2441

Merged
broody merged 3 commits intomainfrom
fix/iframe-close-header
Feb 25, 2026
Merged

fix: prefer close over back in iframe header#2441
broody merged 3 commits intomainfrom
fix/iframe-close-header

Conversation

@broody
Copy link
Contributor

@broody broody commented Feb 25, 2026

Summary

  • make iframe/popup header default to close instead of back
  • keep explicit force-back behavior unchanged for screens that opt in
  • scope this PR to header navigation behavior only

Test plan

  • Run repo hooks/tests via commit hook
  • Open popup flows (connect/starterpack/update-session) and verify close icon is shown instead of back

@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Feb 25, 2026 1:14am
keychain Ready Ready Preview Feb 25, 2026 1:14am
keychain-storybook Ready Ready Preview Feb 25, 2026 1:14am

Request Review

Ensure popup/iframe flows default to showing a close action instead of back navigation, while still allowing explicit force-back behavior.
@claude
Copy link
Contributor

claude bot commented Feb 25, 2026

Claude finished @broody's task —— View job


Documentation Analysis Complete

  • Analyze the code change to understand user-facing impact
  • Search docs repository for related content
  • Determine if documentation updates are needed
  • Update docs if necessary (or explain why not needed)

Summary

No documentation updates needed.

This PR changes internal UI behavior in the NavigationHeader component (preferring "close" over "back" in iframe/popup contexts). This is an internal keychain implementation detail that:

  • Does not affect any documented APIs or configuration options
  • Is not referenced anywhere in the user-facing documentation
  • Represents UI polish rather than a feature or API change
  • Falls under the "DEFAULT TO NO CHANGES" rule for internal refactors and UI improvements

The documentation focuses on API usage, configuration, and session policies - not on internal keychain UI component behavior. Similar to changing button colors or layouts, this type of UI refinement doesn't require documentation updates.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant