Skip to content

feat: activity tab review#2413

Merged
rsodre merged 8 commits intomainfrom
rsodre/activity-tab
Feb 17, 2026
Merged

feat: activity tab review#2413
rsodre merged 8 commits intomainfrom
rsodre/activity-tab

Conversation

@rsodre
Copy link
Collaborator

@rsodre rsodre commented Feb 13, 2026

  • Fixed data fetching in the Activity tab (erc-20, erc-721, achievements)
  • Updated Activity tab layouts (main, erc-20, erc-721, erc-1155)
  • Changed the default mono font to LD_Mono, used on all action buttons
  • Added loading skeleton to token details page
  • Make collectible cards clickable

@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Feb 17, 2026 7:51pm
keychain Ready Ready Preview Feb 17, 2026 7:51pm
keychain-storybook Ready Ready Preview Feb 17, 2026 7:51pm

Request Review

@rsodre rsodre merged commit 112c53f into main Feb 17, 2026
12 checks passed
@rsodre rsodre deleted the rsodre/activity-tab branch February 17, 2026 20:17
@claude
Copy link
Contributor

claude bot commented Feb 17, 2026

Claude finished @rsodre's task —— View job


Documentation analysis complete ✓

Todo List

  • Analyze PR changes to determine user-facing impact
  • Review documentation structure in docs-repo
  • Determine if documentation updates are needed
  • Document reasoning

Analysis

I've analyzed PR #2413 ("feat: activity tab review") and determined that no documentation updates are required.

Reasoning

The changes in this PR are internal UI/UX improvements to the Keychain package that do not affect the public API or require developer action:

  1. Internal component refactoring: The changes modify internal React components in packages/keychain/src/components/ (activity.tsx, token/token.tsx, provider/data.tsx, etc.)

  2. UI improvements only:

    • Fixed data fetching logic (internal implementation detail)
    • Updated layouts and styling (visual changes, not API changes)
    • Changed default mono font to LD_Mono (styling)
    • Added loading skeletons (UI enhancement)
    • Made collectible cards clickable (UX improvement)
  3. No developer-facing API changes: The PR doesn't introduce new methods, change configuration options, or alter how developers integrate with the Controller. The existing documentation in:

    • docs-repo/src/pages/controller/inventory.md (covers inventory management and configuration)
    • docs-repo/src/pages/controller/overview.md (covers key features including achievements)

    ...remains accurate and complete.

  4. Activity tab is internal: The Activity tab is part of the Keychain UI that developers access via controller.openProfile("inventory"). The internal improvements to how activity data is displayed don't change the integration method or require new documentation.

Conclusion

Following the directive to "DEFAULT TO NO CHANGES" for internal refactors and UI changes, no documentation updates are needed. The improvements enhance the user experience without changing how developers interact with the Controller SDK.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants