Add support to CLI to read PRT data by renatomaia · Pull Request #737 · cartesi/rollups-node

renatomaia · 2026-02-19T18:01:57Z

closes #722

Copilot

Pull request overview

This PR adds CLI support for reading PRT (Permissionless Referee Tournament) dispute entities (tournaments, commitments, matches, match_advances) to align with the JSON-RPC API. It also refactors existing read commands for consistency and improves the repository/JSON-RPC layers by changing filter field types from strings to proper address types.

Changes:

Added four new CLI read commands for PRT dispute entities (tournaments, commitments, matches, match_advances)
Refactored existing read commands (epochs, inputs, outputs, reports) for consistency in structure and error handling
Changed CommitmentFilter.TournamentAddress and MatchFilter.TournamentAddress from *string to *common.Address in the repository layer
Renamed GetProcessedInputs to GetProcessedInputCount in the repository interface
Exported parseIndex as ParseIndex in JSON-RPC for broader use
Fixed JSON field naming: IDHash → IdHash to match OpenRPC spec (snake_case id_hash)

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 31 comments.

Show a summary per file

File	Description
`internal/repository/repository.go`	Changed filter field types to use `common.Address` instead of `string`; renamed method to `GetProcessedInputCount`
`internal/repository/postgres/match.go`	Updated to use `common.Address` type directly from filter, removing intermediate conversion
`internal/repository/postgres/commitment.go`	Updated to use `common.Address` type directly from filter, removing intermediate conversion
`internal/repository/postgres/application.go`	Renamed `GetProcessedInputs` to `GetProcessedInputCount`
`internal/jsonrpc/types.go`	Fixed JSON field names from `IDHash` to `IdHash` to match OpenRPC spec
`internal/jsonrpc/jsonrpc.go`	Exported `parseIndex` as `ParseIndex`; updated filter handling to parse addresses before assigning to filters; updated all references to use new field names
`cmd/cartesi-rollups-cli/root/read/tournaments/tournaments.go`	New CLI command for reading tournaments
`cmd/cartesi-rollups-cli/root/read/commitments/commitments.go`	New CLI command for reading commitments
`cmd/cartesi-rollups-cli/root/read/matches/matches.go`	New CLI command for reading matches
`cmd/cartesi-rollups-cli/root/read/match_advances/match_advances.go`	New CLI command for reading match advances
`cmd/cartesi-rollups-cli/root/read/read.go`	Wired new commands into the CLI
`cmd/cartesi-rollups-cli/root/read/epochs/epochs.go`	Refactored for consistency with new command structure
`cmd/cartesi-rollups-cli/root/read/inputs/inputs.go`	Refactored for consistency with new command structure
`cmd/cartesi-rollups-cli/root/read/outputs/outputs.go`	Refactored for consistency with new command structure
`cmd/cartesi-rollups-cli/root/read/reports/reports.go`	Refactored for consistency with new command structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-20T15:28:53Z

cmd/cartesi-rollups-cli/root/read/matches/matches.go

+		if err != nil {
+			cobra.CheckErr(fmt.Errorf("invalid epoch index value: %w", err))
+		}
+


The tournament address argument (args[2]) and ID hash argument (args[3]) should be validated before being passed to the repository. The JSON-RPC handler validates the tournament address using config.ToAddressFromString and validates the ID hash using config.ToHashFromString. Add similar validation here.

Suggested change

// Validate tournament address and id hash arguments

if _, err := config.ToAddressFromString(args[2]); err != nil {

cobra.CheckErr(fmt.Errorf("invalid tournament address value: %w", err))

}

if _, err := config.ToHashFromString(args[3]); err != nil {

cobra.CheckErr(fmt.Errorf("invalid id hash value: %w", err))

}

cmd/cartesi-rollups-cli/root/read/inputs/inputs.go

cmd/cartesi-rollups-cli/root/read/tournaments/tournaments.go

cmd/cartesi-rollups-cli/root/read/matches/matches.go

cmd/cartesi-rollups-cli/root/read/commitments/commitments.go

cmd/cartesi-rollups-cli/root/read/matches/matches.go

cmd/cartesi-rollups-cli/root/read/match_advances/match_advances.go

Copilot · 2026-02-20T15:29:01Z

cmd/cartesi-rollups-cli/root/read/tournaments/tournaments.go

+		if err != nil {
+			cobra.CheckErr(fmt.Errorf("invalid application value: %w", err))
+		}
+


The tournament address argument (args[1]) should be validated before being passed to the repository. The JSON-RPC handler validates this using config.ToAddressFromString. Add validation similar to line 131 where the flag value is validated.

Suggested change

if _, err := config.ToAddressFromString(args[1]); err != nil {

cobra.CheckErr(fmt.Errorf("invalid tournament address value: %w", err))

}

cmd/cartesi-rollups-cli/root/read/matches/matches.go

cmd/cartesi-rollups-cli/root/read/inputs/inputs.go

mpolitzer

Raised a few nitpicks, looking great other than that.

mpolitzer · 2026-02-23T13:32:13Z

cmd/cartesi-rollups-cli/root/read/commitments/commitments.go

+)
+
+var Cmd = &cobra.Command{
+	Use:     "commitments [application-name-or-address] [epoch-index] [tournament-address] [commitment-hash]",


Suggested change

Use: "commitments [application-name-or-address] [epoch-index] [tournament-address] [commitment-hash]",

Use: "commitments <application-name-or-address> [epoch-index] [tournament-address] [commitment-hash]",

mpolitzer · 2026-02-23T13:35:07Z

cmd/cartesi-rollups-cli/root/read/commitments/commitments.go

+			Offset: offset,
+		}, false)
+		cobra.CheckErr(err)
+


Should we check if application exists in case of an len(commitments) == 0 like we do in the jsonrpc?

Same for other "list" like commands.

mpolitzer · 2026-02-23T13:41:13Z

cmd/cartesi-rollups-cli/root/read/epochs/epochs.go


 var Cmd = &cobra.Command{
-	Use:     "epochs [application-name-or-address]",
+	Use:     "epochs [application-name-or-address] [epoch-index]",


Suggested change

Use: "epochs [application-name-or-address] [epoch-index]",

Use: "epochs <application-name-or-address> [epoch-index]",

mpolitzer · 2026-02-23T13:47:35Z

cmd/cartesi-rollups-cli/root/read/matches/matches.go

+)
+
+var Cmd = &cobra.Command{
+	Use:     "matches [application-name-or-address] [epoch-index] [tournament-address] [id-hash]",


Suggested change

Use: "matches [application-name-or-address] [epoch-index] [tournament-address] [id-hash]",

Use: "matches <application-name-or-address> [epoch-index] [tournament-address] [id-hash]",

mpolitzer · 2026-02-23T13:50:14Z

cmd/cartesi-rollups-cli/root/read/reports/reports.go

 )

 var Cmd = &cobra.Command{
 	Use:     "reports [application-name-or-address] [report-index]",


Suggested change

Use: "reports <application-name-or-address> [report-index]",

mpolitzer · 2026-02-23T13:50:33Z

cmd/cartesi-rollups-cli/root/read/outputs/outputs.go

 )

 var Cmd = &cobra.Command{
 	Use:     "outputs [application-name-or-address] [output-index]",


Suggested change

Use: "outputs <application-name-or-address> [output-index]",

mpolitzer · 2026-02-23T13:51:04Z

cmd/cartesi-rollups-cli/root/read/inputs/inputs.go

 )

 var Cmd = &cobra.Command{
 	Use:     "inputs [application-name-or-address] [input-index]",


Suggested change

Use: "inputs <application-name-or-address> [input-index]",

mpolitzer · 2026-02-23T13:51:47Z

cmd/cartesi-rollups-cli/root/read/tournaments/tournaments.go

+)
+
+var Cmd = &cobra.Command{
+	Use:     "tournaments [application-name-or-address] [tournament-address]",


Suggested change

Use: "tournaments [application-name-or-address] [tournament-address]",

Use: "tournaments <application-name-or-address> [tournament-address]",

renatomaia requested review from mpolitzer and vfusco February 19, 2026 18:01

renatomaia self-assigned this Feb 19, 2026

renatomaia force-pushed the features/cli-read-prt-data branch from efdc751 to 305b9fd Compare February 19, 2026 19:42

vfusco requested a review from Copilot February 20, 2026 15:20

Copilot started reviewing on behalf of vfusco February 20, 2026 15:20 View session

vfusco added this to Node Unit Feb 20, 2026

vfusco added this to the 2.0.0 milestone Feb 20, 2026

Copilot AI reviewed Feb 20, 2026

View reviewed changes

renatomaia force-pushed the features/cli-read-prt-data branch from e84cea7 to 1b7160a Compare February 20, 2026 19:01

fix(cli): fix help message for command read epochs

b6aa328

renatomaia force-pushed the features/cli-read-prt-data branch 2 times, most recently from d93c155 to ac88e77 Compare February 20, 2026 22:35

renatomaia added 5 commits February 20, 2026 22:30

feat(cli): add support to read tournament data

2b6742d

feat(cli): add support to read commitment data

e299a41

feat(cli): add support to read matches data

ad7f3b8

feat(cli): add support to read match advances data

71ee722

refactor(cli): print message for data not found

90c3e94

renatomaia force-pushed the features/cli-read-prt-data branch from ac88e77 to 90c3e94 Compare February 21, 2026 03:19

mpolitzer reviewed Feb 23, 2026

View reviewed changes

+		// Validate tournament address and id hash arguments
+		if _, err := config.ToAddressFromString(args[2]); err != nil {
+			cobra.CheckErr(fmt.Errorf("invalid tournament address value: %w", err))
+		}
+		if _, err := config.ToHashFromString(args[3]); err != nil {
+			cobra.CheckErr(fmt.Errorf("invalid id hash value: %w", err))
+		}

	Use: "commitments [application-name-or-address] [epoch-index] [tournament-address] [commitment-hash]",
	Use: "commitments <application-name-or-address> [epoch-index] [tournament-address] [commitment-hash]",

	Use: "epochs [application-name-or-address] [epoch-index]",
	Use: "epochs <application-name-or-address> [epoch-index]",

	Use: "matches [application-name-or-address] [epoch-index] [tournament-address] [id-hash]",
	Use: "matches <application-name-or-address> [epoch-index] [tournament-address] [id-hash]",


	Use: "reports <application-name-or-address> [report-index]",


	Use: "outputs <application-name-or-address> [output-index]",

	Use: "tournaments [application-name-or-address] [tournament-address]",
	Use: "tournaments <application-name-or-address> [tournament-address]",

Comments

Conversation

renatomaia commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mpolitzer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants