fix: check SHA-256 hash of release artifact#240
Merged
Conversation
GCdePaula
approved these changes
Feb 14, 2026
Collaborator
GCdePaula
left a comment
GCdePaula
left a comment
There was a problem hiding this comment.
Left a minor comment!
Collaborator
There was a problem hiding this comment.
Should you instead run the justfile target you updated in this CI step?
Collaborator
Author
There was a problem hiding this comment.
The CI workflow already did wget, so I didn't want to change the workflow.
If we can use the just target, we can do that in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's good practice to check the hash of a downloaded file, to avoid supply-chain attacks.
Besides this change, this PR also:
Forces
wgetto write the file toadd-generated-files.diffby passing the-Ooption. Without such option,wgetmay avoid writing overadd-generated-files.diffand instead write toadd-generated-files.diff.SUFFIXwhereSUFFIXis some suffix added bywgetto avoid collision with an already-existing file.Removes the
add-generated-files.difffile after applying it. This ensures the Git submodule atmachine/emulatorstays clean after the repository is setup.