feat(cli): send generic eip-712 transaction#176
feat(cli): send generic eip-712 transaction#176fabiooshiro wants to merge 3 commits intocartesi:chore/bump-espresso-reader-to-0.3.0from
Conversation
|
85813d5 to
bd55545
Compare
5cfc664 to
43b4863
Compare
| new Option( | ||
| "--node-base-url <url>", | ||
| "Node base url", | ||
| ).default("http://localhost:8080"), |
There was a problem hiding this comment.
Shouldn't this option refer to the URL of the transaction submission service to be used?
Maybe something like --eip712-tx-url, with a default value of http://localhost:8080/transaction?
apps/cli/src/commands/send/eip712.ts
Outdated
| }; | ||
|
|
||
| const DEFAULT_SEND_CONFIG: Readonly<SendOptions> = { | ||
| baseUrl: "http://localhost:8080", |
There was a problem hiding this comment.
Should this be http://localhost:8080/transaction? Isn't this duplicating the option config in generic.ts? (pardon my ignorance)
apps/cli/src/commands/send/eip712.ts
Outdated
| }; | ||
|
|
||
| /** Sends a transaction to L2 */ | ||
| export const sendToL2 = async ( |
There was a problem hiding this comment.
Given that we decided to call the command send --type=eip712, wouldn't it make more sense to call this method sendEip712() or something like that? Similar reasoning applies to other xyzL2() methods above
68b70cc to
5ec208c
Compare
tuler
left a comment
There was a problem hiding this comment.
Hold this to wait for next node alpha along with updated compatible espresso-reader
128eb04 to
8838eeb
Compare
|
I'm getting this error when trying to send: ❯ cartesi-dev send generic --type=eip712 --input=0xdeadbeef 10:54
✔ Chain Foundry
✔ RPC URL http://127.0.0.1:8545
HTTP request failed.
URL: http://127.0.0.1:8545
Request body: {"method":"eth_chainId"}
Details: fetch failed
Version: viem@2.21.32 |
|
I think this needs a rebase. |
0572649 to
1b2334b
Compare
8b7d29b to
bcf32e1
Compare
bcf32e1 to
359bcde
Compare
|
rebased |
|
Command Sending two inputs and I get this from espresso-reader logs: Not sure if it's an issue for this PR, since the inputs is being sent. |
7f014f9 to
54f1c12
Compare
|
@endersonmaia Since the branch cartesi:chore/bump-espresso-reader-to-0.3.0 was deleted, I rebased and reopened the PR #275 |
Draft implementation related to the discussion at #171
Usage