refactor: migrate event listeners to runtime subscriptions for better modularity#141
Merged
refactor: migrate event listeners to runtime subscriptions for better modularity#141
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors event listener management by centralizing Tauri event subscriptions into a dedicated runtime module, improving code modularity and reducing duplication across hooks.
Changes:
- Introduces a centralized
tauriEventRuntime.tsmodule that manages all Tauri event listeners with a pub-sub pattern - Migrates four hooks (
useRecentFSEvents,useDataLoader,useAppWindowListeners,useAppHotkeys) to use the new runtime subscription API - Updates all corresponding tests to mock the runtime subscriptions instead of Tauri APIs directly
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
cardinal/src/runtime/tauriEventRuntime.ts |
New runtime module implementing centralized event subscription management with singleton initialization pattern |
cardinal/src/main.tsx |
Initializes the event runtime at application startup |
cardinal/src/hooks/useRecentFSEvents.ts |
Migrated from direct Tauri event listener to runtime subscription, removed validation logic (now centralized) |
cardinal/src/hooks/useDataLoader.ts |
Simplified to use runtime subscription for icon updates, removed inline type casting |
cardinal/src/hooks/useAppWindowListeners.ts |
Refactored to use runtime subscriptions, split into separate useEffect hooks per subscription |
cardinal/src/hooks/useAppHotkeys.ts |
Migrated Quick Look keydown handling to runtime subscription |
cardinal/src/hooks/__tests__/useRecentFSEvents.test.ts |
New test file verifying runtime subscription integration |
cardinal/src/hooks/__tests__/useDataLoader.test.ts |
Updated to mock runtime instead of Tauri event API, added cleanup test |
cardinal/src/hooks/__tests__/useAppWindowListeners.test.ts |
Refactored to mock runtime subscriptions, verifies all subscription cleanups |
cardinal/src/hooks/__tests__/useAppHotkeys.test.ts |
Updated to mock runtime subscription instead of Tauri event API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.