Refactor Docker config #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All our docker-compose images share this Dockerfile. So, we should move runtime stuff into docker-compose.yml from Dockerfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All our docker-compose images share a single Dockerfile. So, we should move runtime stuff into docker-compose.yml from Dockerfile.
HOWEVER, this does not solve the mcp-server failure. Docker log shows that the mcp-server started a server on port 8000 instead of the intended port 3001.
I believe that is due to the
app/main.pyitself started a server at port 8000. The Python code has a lot of issues like this (e.g., hard-coded port numbers, explicit server start, duplicated MCP functions etc). We should probably fix them in order for the MCP server to start correctly.