Update Docker configuration to use Cardea instead of openmcp and enhance Dockerfile with error handling for installation #19
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce Dockerfile with error handling for installation
Contributor
Author
|
plzz review it @juntao @Acuspeedster |
Collaborator
Acuspeedster
left a comment
Acuspeedster
left a comment
There was a problem hiding this comment.
@juntao Tests passes... I checked the pr. It seems correct to me. We can merge.
Contributor
|
Thank you @alokdangre and @Acuspeedster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build was failing because the installer script for the MCP proxy tried to update shell configs and exited with an error even though the binary was installed correctly. Later the container was also crashing because the compose file was starting with openmcp, but the installer only provides the cardea binary. I fixed this by making the build ignore the non-critical error and updating the compose file to use cardea instead of openmcp.