Skip to content

Fix up KeySpace tasks to use the supplied config #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bossmc
Copy link

@bossmc bossmc commented Jan 24, 2013

Comment in the code explains the fix, YAML returns the config hash as String=>Value, but when working out the settings for the KeySpace creation task, you merge it with a has that is Symbol=>Value.

This fix ensures that we always use the Symbol=>Value version (which is what the Cassandra gem wants as well).

I needed this fix to get the 0.2 version of your gem to work with Cassandra 1.1 where LocalStrategy is no longer allowed. The other thing I had to change was to use:

test:
  servers: "127.0.0.1:9160"
  keyspace: "myapp_test"
  strategy_class: "SimpleStrategy"
  strategy_options: { replication_factor: "1" }
  thrift:
    timeout: 3
    retries: 2

Since Cassandra 1.1 no longer lets you pass the replication factor in on it's own, it has to be embedded in the strategy_options hash...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant