fix clippy issues #567
fix clippy issues #567
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #567 +/- ##
==========================================
- Coverage 51.64% 50.73% -0.92%
==========================================
Files 69 70 +1
Lines 33735 32239 -1496
==========================================
- Hits 17422 16355 -1067
+ Misses 16313 15884 -429 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| with: | ||
| toolchain: nightly-2025-05-13 |
There was a problem hiding this comment.
In #458 (comment) we decided that it was preferable for the nightly to be pinned, so that CI does not spontaneously break.
There was a problem hiding this comment.
This is OK, don't be so obsessed. This helps at least catch some up-to-date linting errors
| @@ -752,14 +752,14 @@ pub mod node { | |||
| 11 => <crate::schema_capnp::node::annotation::Owned as crate::introspect::Introspect>::introspect(), | |||
| 12 => <crate::struct_list::Owned<crate::schema_capnp::node::parameter::Owned> as crate::introspect::Introspect>::introspect(), | |||
| 13 => <bool as crate::introspect::Introspect>::introspect(), | |||
| _ => panic!("invalid field index {}", index), | |||
| _ => panic!("invalid field index {index}"), | |||
There was a problem hiding this comment.
Does this change (and the others in the generated _capnp.rs files) mean that regenerate-capnp-schema-code.sh and regenerate-rpc-schema-code.sh no longer suffice for regenerating these files?
There was a problem hiding this comment.
Please check, all have linting issues with nightly.
There was a problem hiding this comment.
Since these files are used to generate Rust files in the target project, we need to mark them as exceptions in our project. This PR resolves that inconvenient issue.
Look here
|
#570 is one way to the generated code to pass Clippy while still working on Rust 2015. |
This PR fixes the clippy issues (nightly version)