Skip to content

feat: metrics for outboxed services #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 75 commits into from
Jul 16, 2025
Merged

feat: metrics for outboxed services #339

merged 75 commits into from
Jul 16, 2025

Conversation

PDT42
Copy link
Contributor

@PDT42 PDT42 commented May 13, 2025

Add collection of queue metrics - unless the feature is disabled - by registering a done handler, which will trigger metrics collection. Metrics collection for a queued service will start once the service in question is found to be the target of a queued message for the first time.

Correct collection of the cold_entries metric depends on the maxAttempts queue configuration being available from the queued service, which is not yet the case for cds^8. For cds^8 maxAttempts is currently being defaulted (to 20).

Counts of incoming_messages and outgoing_messages are currently being collected per tenant per app instance and AFAIK should be aggregated per tenant by the collector.

Copy link
Contributor

@sjvans sjvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i want to go over the lingo "outbox" vs "queue" one more time. plus, we should also optimize local export to console like we do for db pool metrics before we release. otherwise we will spam the console!

Copy link
Contributor

@sjvans sjvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sjvans sjvans merged commit 20187df into main Jul 16, 2025
13 checks passed
@sjvans sjvans deleted the feat-outbox-metrics branch July 16, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants