-
Notifications
You must be signed in to change notification settings - Fork 12
feat: metrics for outboxed services #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! i want to go over the lingo "outbox" vs "queue" one more time. plus, we should also optimize local export to console like we do for db pool metrics before we release. otherwise we will spam the console!
Co-authored-by: sjvans <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Add collection of queue metrics - unless the feature is disabled - by registering a
done
handler, which will trigger metrics collection. Metrics collection for a queued service will start once the service in question is found to be thetarget
of a queued message for the first time.Correct collection of the
cold_entries
metric depends on themaxAttempts
queue configuration being available from the queued service, which is not yet the case for cds^8. For cds^8maxAttempts
is currently being defaulted (to 20).Counts of
incoming_messages
andoutgoing_messages
are currently being collected per tenant per app instance and AFAIK should be aggregated per tenant by the collector.