Skip to content

Test test_smoke.py without test_app_resources_conflicts_v3 #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 35 commits into
base: 16/edge
Choose a base branch
from

Conversation

carlcsaposs-canonical
Copy link
Contributor

No description provided.

Exception is already chained

> A similar mechanism works implicitly if a new exception is raised when an exception is already being handled. An exception may be handled when an except or finally clause, or a with statement, is used. The previous exception is then attached as the new exception’s __context__ attribute:

https://docs.python.org/3/reference/simple_stmts.html#the-raise-statement
Fixes breaking change where charm re-initialized on defferred events, which breaks refresh v3
@carlcsaposs-canonical carlcsaposs-canonical force-pushed the refresh-v3-3 branch 2 times, most recently from b8fbe52 to 21f2945 Compare May 7, 2025 14:28
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 49.33333% with 114 lines in your changes missing coverage. Please review.

Project coverage is 69.35%. Comparing base (3f81441) to head (21f2945).

Files with missing lines Patch % Lines
src/charm.py 50.51% 85 Missing and 11 partials ⚠️
src/relations/async_replication.py 16.66% 14 Missing and 1 partial ⚠️
src/relations/postgresql_provider.py 25.00% 3 Missing ⚠️

❌ Your project check has failed because the head coverage (69.35%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           16/edge     #887      +/-   ##
===========================================
- Coverage    70.67%   69.35%   -1.33%     
===========================================
  Files           15       14       -1     
  Lines         3956     3955       -1     
  Branches       590      596       +6     
===========================================
- Hits          2796     2743      -53     
- Misses         970     1015      +45     
- Partials       190      197       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant