-
Notifications
You must be signed in to change notification settings - Fork 740
[docs] Add instructions for windows build to run the GUI #4505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ricab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tobe2098, a few questions and suggestions from my end.
|
|
||
| ```[pwsh] | ||
| choco install cmake ninja qemu openssl git wget unzip -yfd | ||
| choco install cmake ninja qemu-img openssl git wget unzip -yfd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like qemu-img is stuck at 2.3.0 in choco, whereas qemu comes with qemu-img 10.1.0. I see you replaced it in 56402e1 (inadvertently?) but I wonder if we should use such an outdated version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I changed it (or maybe we should add it instead?) Was that just with qemu multipass hangs on launch being unable to convert to the vhdx format without qemu-img. Once I installed it it worked fine, buy before it would not be able to launch an instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the reason why you changed it back, or why you changed to qemu at first? And did you have qemu-img in the path?
Anyway, I think I remember having similar problems with newer qemu, so fine for now, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first I think we noticed the version and kept qemu for being newer, but now I found this issue with missing qemu-img. I have added it back (now there are the two of them), until we have an opportunity to test with a clean install again. Both qemu and qemu-img are added to the Path by choco I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From uninstalling qemu-img and installing qemu it seems like choco does not add the second one to Path. Should we suggest the use of qemu-img or should we suggest a Path fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After further research, qemu-img is the utility that we need, not qemu, since multipass does no emulation in windows. It is a sub-utility of qemu, not part of the package necessarily, so we could drop installing qemu as a whole for the utility. Apart from the apparent Path problems with Chocolatey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, choco installs qemu in a separate folder instead of inside chocolatey/bin/, which is added to the path, while the other is not. Uninstalling also has weird behavior, there are files left behind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so the decision is between a severily outdated qemu-img or installing a bunch of stuff we don't need and adding it to the path. Did launch work for you with the qemu folder in the path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More or less. I have not tried, but qemu-img is in that folder, so it is a solid assumption that adding to the path will work. Since it is so outdated, maybe it is worth getting the whole QEMU package. If we are already changing the path for cmake and qt, it would just be one more.
BUILD.windows.md
Outdated
| ### Run `multipass` | ||
|
|
||
| With the `multipassd` daemon now running on another shell (or as a windows service) you can now run `multipass`. | ||
| You can also add `<multipass>/build/bin` to the Path environment variable to be able to run the commands from anywhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invert slashes?
But also, how about introducing a separate section with instructions for extending the Path, so that it could be referred to from ### Run multipass{,.gui}?
BUILD.windows.md
Outdated
| - `<multipass>\build\bin` | ||
| - `<multipass>\build\bin\windows\x64\runner\Release` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to include a PowerShell command to add these. Preferably in the current shell (and children) only, to avoid conflicts with installed Multipass packages (e.g. new libraries or executables present here but not there, so cross loaded between installs)
cbafc29 to
32e4bca
Compare
Installing qemu does not seem to be enough for vhdx conversion. It times out instantly. Installing qemu-img fixes the issue.
Add instructions for QOL improvements and to make clear how to run the multipass GUI seamlessly. They consist only of Path adjustments.
32e4bca to
7ed30c9
Compare
ricab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tobe2098, not sure if you still mean to test with choco qemu, but I am fine with this as it is for now. Feel free to ping if you still need to make changes.
Added missing instructions on how to run the GUI, which is fairly simple. I also added the addition of putting the
<multipass>/build/binin the path for convenience, and corrected a possible mistake in the installation of qemu/qemu-img.