Refactor: Strip full file paths from SSH process logs #4440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
ricab
requested changes
Oct 16, 2025
Collaborator
ricab
left a comment
ricab
left a comment
There was a problem hiding this comment.
Hey @prachimaskar, I think you forgot something. Please remember to test before submitting.
Contributor
Author
|
Hi @ricab, Apologies for the earlier oversight. I have now implemented the suggested changes, including updating the log calls and adding the required include. Kindly review at your convenience. Thank you for your guidance and support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the previous PR #4196, which was closed automatically after the C++20 branch was deleted.
Changes:
Refactored SSH process logging to strip full file paths and display only the filename using std::source_location and consteval.
Why this PR is needed:
Improves log readability.
Enhances security by avoiding exposure of full file paths.