Skip to content

add a check if wakealarm is supported (bugfix) #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aglinserer
Copy link
Contributor

Description

This avoids a failing test and skips it instead if the rtc does not support an automatic wakeup.
The suspend_advanced_auto job is failing even though it cannot be run when the wakealarm is not supported.

Resolved issues

N/A

Documentation

N/A

Tests

N/A

Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.22%. Comparing base (dc0c59e) to head (fd11931).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1921      +/-   ##
==========================================
- Coverage   50.47%   50.22%   -0.25%     
==========================================
  Files         382      382              
  Lines       41055    40809     -246     
  Branches     6895     6847      -48     
==========================================
- Hits        20722    20496     -226     
+ Misses      19587    19579       -8     
+ Partials      746      734      -12     
Flag Coverage Δ
provider-base 25.66% <ø> (-1.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This avoids a failing test and skips it instead if the rtc does
not support an automatic wakeup.
@aglinserer aglinserer changed the title add a check if wakealarm is supported (fix) add a check if wakealarm is supported (bugfix) May 13, 2025
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

I left a comment inline.

Can you describe the use case you have and the issue you're encountering? This job is very sensitive because it's used in almost every test plan we maintain, so modifying it is always a bit risky.

This is a easier to read syntax which essentially does the same thing.

Co-authored-by: Pierre Equoy <[email protected]>
@aglinserer
Copy link
Contributor Author

Can you describe the use case you have and the issue you're encountering? This job is very sensitive because it's used in almost every test plan we maintain, so modifying it is always a bit risky.

Currently, I am running Checkbox on hardware that does not support the wakealarm functionality. My thought is that if the interface or functionality is not supported, failing this test - based solely on rtc.state == supported and mem.sleep == supported - is incorrect. I would assume that checking for wakealarm functionality should be a requirement for this since it depends on this.

After giving it some more thought you could also interpret suspendability as a basic requirement. Then failing this would be the correct choice. This thought only occured after creating this pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants