SRIOV tests and unit tests (New) #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriov checkbox files
|
@mreed8855 you seem to have forgotten to commit and push your |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1761 +/- ##
==========================================
+ Coverage 51.13% 51.70% +0.56%
==========================================
Files 386 387 +1
Lines 41603 41526 -77
Branches 7730 7706 -24
==========================================
+ Hits 21272 21469 +197
+ Misses 19569 19295 -274
Partials 762 762
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pedro-avalos
changed the title
pedro-avalos
requested changes
Mar 26, 2025
There was a problem hiding this comment.
I have a few issues with some of the functions, but overall the test looks good.
After making these changes and updating the tests, you should run and submit a test run with a local clone of checkbox; then link the submission in the tests section of this PR, so we can review if the test runs successfully.
Moved the checkbox jobs to networking
pedro-avalos
requested changes
Jul 21, 2025
pedro-avalos
requested changes
Jul 22, 2025
mreed8855
added a commit
that referenced
this pull request
Jul 30, 2025
Creates and SRIOV device in either a virtual machine or container
- Adding a cleanup sriov script to remove virtual adapters after
a test is run
- Add has_sriov manifest entry to enable SR-IOV testing
- Add info/sriov-check_{interface} template test that checks /sys/class/net/{interface}/device/sriov_numvfs
- Update SR-IOV LXD tests to depend on interface-specific SR-IOV capability check
- Only SR-IOV enabled interfaces will run the functional tests
- Only SR-IOV enabled interfaces will run the functional tests
- Add info/sriov-check_{interface} template test that check
if SR-IOV is enabled for an interface
- Update SR-IOV LXD and LXD_VM tests to depend on
interface-specific SR-IOV capability check
mreed8855
added a commit
that referenced
this pull request
Jul 31, 2025
-Removed this file as it was mistakely placed here
-Updated for PR changes
-Removed try except block
-Remove unnecessary else statment
-Remove try except block from check_interface_vendor
-Updates to unit tests
-Removed sys.exit from main
-Adding a cleanup sriov script to remove virtual adapters after
a test is run
-Fix black and flake8 formating
- Add has_sriov manifest entry to enable SR-IOV testing
- Only SR-IOV enabled interfaces will run the functional tests
- Add info/sriov-check_{interface} template test that check
if SR-IOV is enabled for an interface
- Update SR-IOV LXD and LXD_VM tests to depend on
interface-specific SR-IOV capability check
|
Passing Results (Garmond) Test Skipped for an interface that does not have SR-IOV enabled. Test Skipped as SR-IOV is set to false in the manifest entry |
pedro-avalos
approved these changes
Aug 1, 2025
stanley31huang
pushed a commit
that referenced
this pull request
Aug 14, 2025
* SRIOV tests and unit tests
sriov checkbox files
* Updates made to sriov.py and unit tests to increase the coverage
* Updated for black format c heck
* Updates made to address the PR comments
* Updated unit tests
Moved the checkbox jobs to networking
* Moved job file to networking
* Fixed black formatting
* Fix black formatting
* Fixed additional fomatting issues
* Removed this file as it was mistakely placed here
* Fixed black formatting again!
* Updated for PR changes
* removed try except block
* Fix flake8 issue
Remove unnecessary else statment
* Black formatting issue
* flake8 issue
* flake 8 issue
* Remove try except block from check_interface_vendor
* Updates to unit tests
* black formating fix
* Removed line for python 3.5
* Changes made to comply with Python 3.5
* pythong 3.5 issue
* python 3.5 issue
* Removed sys.exit from main
* Adding a cleanup sriov script to remove virtual adapters after
a test is run
* Fix black and flake8 formating
* Fix black formatting
* - Add has_sriov manifest entry to enable SR-IOV testing
- Only SR-IOV enabled interfaces will run the functional tests
- Add info/sriov-check_{interface} template test that check
if SR-IOV is enabled for an interface
- Update SR-IOV LXD and LXD_VM tests to depend on
interface-specific SR-IOV capability check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sriov checkbox files
Description
Resolved issues
This is a replacment for PR #1293
Resolves CHECKBOX-1164
Documentation
Tests