Skip to content

Add vendor specific MIPI camera test plan (New) #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

baconYao
Copy link
Contributor

@baconYao baconYao commented Feb 13, 2025

Description

Resolved issues

N/A

Documentation

Tests

Set the checkbox configuration, due to we want to use the local executable binary.

PLATFORM_NAME=genio-xxx
GST_LAUNCH_BIN=/usr/bin/gst-launch-1.0
MEDIA_CTL_CMD=/usr/bin/media-ctl
V4L2_CTL_CMD=/usr/bin/v4l2-ctl
GST_DISCOVERER=/usr/bin/gst-discoverer-1.0

@baconYao baconYao requested a review from a team February 13, 2025 09:55
@baconYao baconYao changed the title Initial MIPI camera test plan Add vendor specific MIPI camera test plan (New) Feb 14, 2025
@baconYao baconYao marked this pull request as ready for review February 14, 2025 06:37
@fernando79513 fernando79513 added the ce-oem The PR only contains to the ce-oem provider under the contrib area label Feb 27, 2025
@seankingyang seankingyang marked this pull request as draft July 1, 2025 02:07
@seankingyang seankingyang force-pushed the init-camera-framework-in-ce-oem branch from ed17b78 to 0e19df4 Compare July 2, 2025 06:10
@seankingyang seankingyang marked this pull request as ready for review July 3, 2025 02:09
Copy link
Contributor Author

@baconYao baconYao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestion

Copy link
Contributor Author

@baconYao baconYao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix my typo

Copy link
Contributor Author

@baconYao baconYao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestion

Copy link
Contributor Author

@baconYao baconYao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestion, but need to be formatted I think

Copy link
Contributor Author

@baconYao baconYao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seankingyang Please see my opinion.

Copy link
Contributor

@tomli380576 tomli380576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops forgot to press submit review

Copy link
Contributor

@rickwu666666 rickwu666666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my in-line comments

tomli380576
tomli380576 previously approved these changes Jul 29, 2025
Copy link
Contributor

@tomli380576 tomli380576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I think we need to add json validation in another PR

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.66%. Comparing base (6c41015) to head (b3288e9).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1723   +/-   ##
=======================================
  Coverage   51.66%   51.66%           
=======================================
  Files         386      386           
  Lines       41492    41492           
  Branches     7711     7711           
=======================================
  Hits        21435    21435           
  Misses      19294    19294           
  Partials      763      763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ce-oem The PR only contains to the ce-oem provider under the contrib area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants