-
Notifications
You must be signed in to change notification settings - Fork 64
Add vendor specific MIPI camera test plan (New) #1723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ed17b78
to
0e19df4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggestion
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_genio.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix my typo
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_utils.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_test.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_test.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggestion
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_utils.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggestion, but need to be formatted I think
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_genio.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seankingyang Please see my opinion.
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_genio.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops forgot to press submit review
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_utils.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_utils.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_genio.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_genio.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_utils.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_utils.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_utils.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my in-line comments
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_test.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_test.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_test.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_test.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_test.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_test.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but I think we need to add json validation in another PR
…NBOX_PROVIDER_DATA then fall back to the abs path
…PLAINBOX_PROVIDER_DATA then fall back to the abs path
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1723 +/- ##
=======================================
Coverage 51.66% 51.66%
=======================================
Files 386 386
Lines 41492 41492
Branches 7711 7711
=======================================
Hits 21435 21435
Misses 19294 19294
Partials 763 763 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Resolved issues
N/A
Documentation
Tests
Set the checkbox configuration, due to we want to use the local executable binary.
data/Genio-MIPI-Camera-TestScenario-TestSetup/genio_mipi_camera_test_scenario_IMX214_AP1302_AR0830_IMX214.json
>data/Genio-MIPI-Camera-TestScenario-TestSetup/genio_mipi_camera_test_scenario_IMX214_dual.json
>data/Genio-MIPI-Camera-TestScenario-TestSetup/genio_mipi_camera_test_scenario_AP1302_AR0830.json
>data/Genio-MIPI-Camera-TestScenario-TestSetup/genio_mipi_camera_test_setup_AP1302_AR0830.json
>data/Genio-MIPI-Camera-TestScenario-TestSetup/genio_mipi_camera_test_scenario_AP1302_AR0430.json
>data/Genio-MIPI-Camera-TestScenario-TestSetup/genio_mipi_camera_test_setup_AP1302_AR0430.json
>data/Genio-MIPI-Camera-TestScenario-TestSetup/genio_mipi_camera_test_scenario_AR0430.json
>data/Genio-MIPI-Camera-TestScenario-TestSetup/genio_mipi_camera_test_setup_AR0430.json
>