Skip to content

fix: csp console errors - #2807

Merged
Skazitron merged 6 commits into
mainfrom
csp-errors-fix
Jul 24, 2026
Merged

fix: csp console errors#2807
Skazitron merged 6 commits into
mainfrom
csp-errors-fix

Conversation

@Skazitron

@Skazitron Skazitron commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@webteam-app

Copy link
Copy Markdown

@Skazitron
Skazitron marked this pull request as draft July 22, 2026 11:46
@Skazitron
Skazitron marked this pull request as ready for review July 22, 2026 13:47
@mtruj013

mtruj013 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Thanks @Skazitron. There are CSP reports in red flagging usabilla on a few different pages (eg /openstack, /consulting, /observability, /data) is this expected?:
image

Comment thread .github/workflows/deploy.yaml Dismissed
Comment thread .github/workflows/deploy.yaml Dismissed
Comment thread .github/workflows/deploy.yaml Dismissed
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.82%. Comparing base (fd31c08) to head (1f82573).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2807      +/-   ##
==========================================
- Coverage   74.90%   74.82%   -0.09%     
==========================================
  Files          19       19              
  Lines        2363     2363              
==========================================
- Hits         1770     1768       -2     
- Misses        593      595       +2     
Flag Coverage Δ
python 74.82% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Skazitron

Skazitron commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@mtruj013 I've reached out to Gianluigi (from GE/Marketing) to remove the Usabilla from GTM. Since there is nothing else we can do in terms of code, I think we can proceed with the code review.

Update: Gianlugi has confirmed he'll remove Usabilla. Here's the associated ticket for it.

Comment thread .github/workflows/deploy.yaml Outdated
@mtruj013

Copy link
Copy Markdown
Contributor

Thanks @Skazitron , looks like the usabilla error is gone across the board but now I see the following on all pages:
Screenshot 2026-07-23 130443
Confirmed against main that same isn't observed on prod

@Skazitron

Copy link
Copy Markdown
Contributor Author

@mtruj013 thanks for the review. Taking another look.

@Skazitron

Skazitron commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@mtruj013 I've deployed it to staging to see if this is just another permission error due to us running the branch locally or if it was caused by our code specifically. I'm leaning towards the former.

@Skazitron

Copy link
Copy Markdown
Contributor Author

The 403 errors disappear on staging, so we should be good. Please take another look @mtruj013

Comment thread .github/workflows/deploy.yaml Outdated
juju refresh canonical-com-blog --path ./canonical-com_ubuntu-22.04-amd64.charm --resource flask-app-image=${{ needs.publish-image.outputs.image_url }}
juju refresh canonical-com-careers --path ./canonical-com_ubuntu-22.04-amd64.charm --resource flask-app-image=${{ needs.publish-image.outputs.image_url }}
juju wait-for application canonical-com --query='name=="canonical-com" && (status=="active" || status=="idle")'
# deploy-production:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging so this is reverted before merging.

@mtruj013 mtruj013 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Skazitron , LGTM! Leaving +1 with changes for the reversion of the work done to deploy.yaml for qa

@Skazitron
Skazitron merged commit 99a5d89 into main Jul 24, 2026
17 of 19 checks passed
@Skazitron
Skazitron deleted the csp-errors-fix branch July 24, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants