feat: add '<gene> mutation' catvars from MOA #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsstevenson
changed the title
DanielPuthawala
approved these changes
Dec 1, 2025
DanielPuthawala
left a comment
DanielPuthawala
left a comment
There was a problem hiding this comment.
The Cat-VRS portion of the example looks correct to me!
mcannon068nw
approved these changes
Dec 3, 2025
Comment on lines
+102
to
+108
| if len(proposition.subjectVariant.constraints) != 1: | ||
| _logger.info( | ||
| "%s could not be loaded because it contains more than 1 constraint: %s", | ||
| statement.id, | ||
| proposition.subjectVariant.constraints, | ||
| ) | ||
| success = False |
There was a problem hiding this comment.
will there ever be a case where a subject variant has more than one constraint?
Member
Author
There was a problem hiding this comment.
Yep! This is a planned future thing but isn't super possible currently. A lot of the parts of this code are basically designed as guards against stuff that isn't supported yet but will be supported eventually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOA examples: https://moalmanac.org/assertion/559, https://moalmanac.org/assertion/521
See here for an example of CDM output:
https://gist.github.com/jsstevenson/5fc111fdff9e7a23efba18bf682341bc