merge: staging changes into main #372
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katie-perry
reviewed
Nov 12, 2025
katie-perry
reviewed
Nov 12, 2025
client/src/components/main/shared/StrandSwitch/StrandSwitch.tsx
Outdated
Show resolved
Hide resolved
katie-perry
reviewed
Nov 12, 2025
client/src/components/Pages/Structure/RegElement/RegElementForm/RegElementForm.tsx
Outdated
Show resolved
Hide resolved
katie-perry
reviewed
Nov 12, 2025
client/src/components/Utilities/GetCoordinates/GetCoordinates.tsx
Outdated
Show resolved
Hide resolved
katie-perry
previously approved these changes
Nov 12, 2025
Contributor
katie-perry
left a comment
katie-perry
left a comment
There was a problem hiding this comment.
sorry this took me like 8 million years to review. It looks solid. I just left some minor comments that can totally be addressed later in a different PR (the biggest concern is really a setState in a render, since a setState will always cause a render, but it looks like there's an if branch that really only runs when the value has changed, so it's like you did a pseudo useEffect), so I'll go ahead and approve!
This reverts commit 1e0b78e.
* remove setState in a render + simplify syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@katiestahl would like you to do a quick review (there were other small UI changes other than #367) to make sure I didn't commit any UI crimes