Skip to content

Fixed history_6rolls_35bag.lua for real.#15

Merged
Tetro48 merged 9 commits intocambridge-stacker:v0.4.x-devfrom
zaphod77:v0.4.x-dev
Jun 25, 2025
Merged

Fixed history_6rolls_35bag.lua for real.#15
Tetro48 merged 9 commits intocambridge-stacker:v0.4.x-devfrom
zaphod77:v0.4.x-dev

Conversation

@zaphod77
Copy link
Copy Markdown
Contributor

The following changes have been made.

  1. implement updating the 35 bag before each reroll.
  2. implement original TI bug that causes the bag to sometimes not update when it was clearly intended.
  3. implemented original fallthrough logic with rerolls. Should the PRNG ever get changed to the one that TGM games other than TGM4 use, this may actually matter. For now it doesn't.
  4. added comments explaining stuff.

Not done:

  1. uses actual reroll logic on first piece instead of the existing clever hack
  2. change piece ids to be same as TI's.

This has been tested, and feels much closer.

@Tetro48
Copy link
Copy Markdown
Contributor

Tetro48 commented May 19, 2025

hey, use camelCase for function names, snake_case for variable names (even if they are local)

@zaphod77
Copy link
Copy Markdown
Contributor Author

okay, i think i have made the required style changes.

@RocketLanterns RocketLanterns added 0.4.x bug Something isn't working labels Jun 25, 2025
@Tetro48 Tetro48 merged commit 6a9e540 into cambridge-stacker:v0.4.x-dev Jun 25, 2025
@zaphod77 zaphod77 deleted the v0.4.x-dev branch June 26, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.4.x bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants