Release r1.1 with 0.1.0-rc.1 version (Fall'25 M3)#15
Merged
JoseMConde merged 9 commits intocamaraproject:mainfrom Jul 24, 2025
Merged
Release r1.1 with 0.1.0-rc.1 version (Fall'25 M3)#15JoseMConde merged 9 commits intocamaraproject:mainfrom
JoseMConde merged 9 commits intocamaraproject:mainfrom
Conversation
jgarciatovar
requested review from
a team,
FabrizioMoggio,
JoseMConde,
Kevsy,
crissancas,
gainsley,
gunjald,
maheshc01 and
seralogar
as code owners
19 tasks
Kevsy
reviewed
Jun 24, 2025
Kevsy
reviewed
Jun 26, 2025
Per API versioning guidelines: "For initial public API versions 0.y.z, the MINOR number MUST be included in the URL, e.g. v0.y. "
Kevsy
previously approved these changes
Jun 26, 2025
Contributor
Kevsy
left a comment
Kevsy
left a comment
There was a problem hiding this comment.
LGTM (version in URL now fixed)
Contributor
|
looks good |
maheshc01
previously approved these changes
Jun 27, 2025
hdamker
requested changes
Jul 1, 2025
Contributor
hdamker
left a comment
hdamker
left a comment
There was a problem hiding this comment.
The prepared pre-release looks already quite good. The .feature file needs some more attention. See comments on included files below.
Regarding .feature file:
- touch the version within line 2 (v0.1.0-rc.1),
- check if line 1 is intended
- change
vwipin line 15 tov0.1rc1 - Use correct scope in line 163 (wrong:
connected-network-type:read) - line 110: correct schema would be
/components/schemas/SingleIpv6Addrnot/components/schemas/DeviceIpv6Address - line 252: wrong scenario name (
@connected_network_type_503_network_error) - Note: would be good to review the .feature file in detail, even after M3
jgarciatovar
dismissed stale reviews from maheshc01, JoseMConde, and Kevsy
via
4c0f60d
Contributor
Author
@hdamker - Thanks for the comments. I'll create an issue to review this .feature file in detail after M3. |
Contributor
Author
|
@hdamker - Requested updates completed. |
hdamker
requested changes
Jul 21, 2025
Contributor
hdamker
left a comment
hdamker
left a comment
There was a problem hiding this comment.
Almost there! Just a few smaller comments to consider.
gunjald
approved these changes
Jul 22, 2025
hdamker
approved these changes
Jul 23, 2025
Contributor
hdamker
left a comment
hdamker
left a comment
There was a problem hiding this comment.
LGTM from Release Management perspective
Contributor
|
@camaraproject/application-endpoint-discovery_codeowners Next actions to be completed for M3:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Publication of Fall'25 M3 release candidate v0.1.0-rc.1
Which issue(s) this PR fixes:
Fixes #8
Special notes for reviewers:
None
Changelog input
Additional documentation
None