fix(storage-plugin): strip from production builds#205
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
V3RON
force-pushed
the
fix/storage-plugin-in-prod
branch
from
21ab7c1 to
cdcd4cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the storage plugin React Native entry point so the adapter factories follow the same guarded pattern as
useRozeniteStoragePlugin. In production, the entry now exposes no-op adapter factories instead of statically re-exporting the real adapter modules, which keeps the storage plugin implementation out of production bundles.Related Issue
N/A
Context
Guarding only the main hook was not enough because the entry file still re-exported
createAsyncStorageAdapter,createExpoAsyncStorageAdapter,createExpoSecureStorageAdapter, andcreateMMKVStorageAdapterdirectly. That forced the adapter implementation into the bundle even when the hook itself was stripped. The entry now lazily requires the real factories only in supported dev React Native environments and returns empty adapters everywhere else.Testing
Not run (entry-point export change only).