-
Notifications
You must be signed in to change notification settings - Fork 280
dynamic sized toast based on content #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hey fellows, any reason this has not been merged yet? |
Not sure... @tgmarinho any insights? |
when merge it? |
This would resolve #539 |
export const BORDER_RADIUS = 6; | ||
|
||
export const styles = StyleSheet.create({ | ||
base: { | ||
flexDirection: 'row', | ||
height: HEIGHT, | ||
width: WIDTH, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep the values, but as minWidth
and minHeight
This can be done by using BaseToast "style" and "contentContainerStyle" props const Toast = (props) => {
return <BaseToast
{...props}
text1NumberOfLines={0}
text2NumberOfLines={0}
contentContainerStyle={styles.contentContainer}
style={styles.base}
/>
}
const styles = StyleSheet.create({
base: {
minHeight: 60,
minWidth: 340,
width: undefined,
height: undefined,
paddingVertical: 16,
},
contentContainer: {
paddingHorizontal: 20,
},
}); |
@davru Certainly there are workarounds, thanks for this one. But it does not discount that this is a bug tbh, UI elements need to be responsive |
No description provided.