Skip to content

feat: add MiniMax image generation tool - #495

Merged
calesthio merged 3 commits into
calesthio:mainfrom
octo-patch:octo/20260812-text-to-image-tool-recvrT5wxxCTQC
Aug 13, 2026
Merged

feat: add MiniMax image generation tool#495
calesthio merged 3 commits into
calesthio:mainfrom
octo-patch:octo/20260812-text-to-image-tool-recvrT5wxxCTQC

Conversation

@octo-patch

Copy link
Copy Markdown
Contributor

Reason: The repository has a provider-discovered image generation registry and multiple first-party text-to-image tools, but no MiniMax image tool or related PR implements the target global/CN image_generation endpoints, current image models, request fields, or URL/base64 response parsing.

Summary:

  • Add a provider-discovered MiniMax image generation tool with global and mainland China endpoint routing.
  • Support the current image models, documented request controls, URL downloads, and base64 image responses.
  • Add focused contract tests for discovery, availability, routing, payloads, output parsing, and provider errors.

Checks:

  • uv run --with-requirements requirements-dev.txt pytest tests/tools/test_minimax_image.py -v
  • uv run --with-requirements requirements-dev.txt python -m py_compile tools/graphics/minimax_image.py tests/tools/test_minimax_image.py
  • uv run --with-requirements requirements-dev.txt pytest tests/tools/test_provider_model_defaults.py tests/tools/test_google_imagen_multi_output.py tests/tools/test_openai_image_multi_output.py -q

@octo-patch
octo-patch requested a review from calesthio as a code owner August 12, 2026 14:46
@SerBeshen

SerBeshen commented Aug 12, 2026 via email

Copy link
Copy Markdown

@calesthio calesthio left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the focused MiniMax image integration. The mocked URL/base64 paths, region routing, status gating, registry registration, multi-output handling, and existing image regressions all pass locally (22 passed).

I found merge-readiness blockers under the provider review guide:

  • This is a paid network provider, but the tool does not implement estimate_cost() and returns no cost_usd. Through the BaseTool default it will be presented as zero-cost during planning, which can lead to ungoverned spend. Please add a documented, model/output-count-aware estimate (or explicitly return unknown when MiniMax does not publish a stable rate) and test it.
  • The PR adds a user-visible provider without updating docs/PROVIDERS.md / .env.example with setup, global-vs-CN routing, pricing/quota caveats, supported models, and limitations.
  • The review guide's minimum provider coverage requires selector routing. The current test registers the module directly, but does not prove that image_selector discovers, selects, and routes a normal request to minimax_image. Please add a fully mocked selector-level test; no live endpoint should be involved.
  • agent_skills = ["flux-best-practices"] is provider-inaccurate: FLUX prompting guidance does not describe MiniMax Image-01. Please add appropriate MiniMax guidance or leave this empty until such a skill exists rather than directing agents to the wrong vendor contract.

The provider itself is useful and the implementation is nicely scoped. Thank you?once cost governance, docs, selector coverage, and skill metadata are corrected, it should be ready for another review.

@calesthio calesthio left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the MiniMax image provider. Provider contracts, selector routing, cost reporting, docs, and tests are complete; the branch is current and CI is green. This is merge-ready.

@calesthio
calesthio merged commit 21d7c79 into calesthio:main Aug 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants