Skip to content

Draft: #2341 PDOAdapter : cast dates #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: 0.x
Choose a base branch
from
Draft

Draft: #2341 PDOAdapter : cast dates #2346

wants to merge 2 commits into from

Conversation

Yopai
Copy link
Contributor

@Yopai Yopai commented Mar 6, 2025

In this PR :

  • a new method "castToDate" is added, to generate Date-specific SQL (allow it to be a TO_DATE expression for the future OCIAdapter)
  • migrated use it to correctly cast startTime and endTime
  • in insert, replace values that have the format of a date, by casting them the same way

For the last, I'm not sure. Maybe use DateTime objects for value would be a better option.

@Yopai Yopai marked this pull request as draft March 6, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Yopai