Skip to content

Fixed setup.py to include version package data#44

Open
mjspeck wants to merge 2 commits intocage-challenge:mainfrom
mjspeck:main
Open

Fixed setup.py to include version package data#44
mjspeck wants to merge 2 commits intocage-challenge:mainfrom
mjspeck:main

Conversation

@mjspeck
Copy link

@mjspeck mjspeck commented Sep 5, 2024

Changes:

  • Updated .gitignore since there are python-related files it wasn't accounting for
  • Minor formatting changes in setup.py due to VSCode auto-formatting extensions
  • Most important: added *.txt files as package data so that version.txt is copied to package location upon installation here

@mjspeck mjspeck mentioned this pull request Sep 6, 2024
@bpshaver
Copy link

Would love to see this merged.

@bpshaver
Copy link

Installation fails unless I clone the repo, which I should not need to do.

$ pip install -q git+https://github.com/cage-challenge/CybORG.git@2742b5e0ce4330c9b14006b38acd3b5ebe00d6fd
$ python -c "import CybORG"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.10/site-packages/CybORG/__init__.py", line 8, in <module>
    with open(path) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/lib/python3.10/site-packages/CybORG/version.txt'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants