fix: allow resolving context-dot for async functions#6085
Draft
christoph-dfinity wants to merge 1 commit intomasterfrom
Draft
fix: allow resolving context-dot for async functions#6085christoph-dfinity wants to merge 1 commit intomasterfrom
christoph-dfinity wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By hardcoding the scope to
Nonebefore, we made it so async functions would never be resolved for context-dot.Threading the scope through fixes that.
Reported by @timohanke
@Kamirus I didn't see an obvious way to get a hold of a
scopefor the context dot suggestions in the LSP, so for now completions for async functions won't appear.TODO: