fix: allow code page to scroll naturally like docs page#363
Open
codecustard wants to merge 1 commit intocaffeinelabs:mainfrom
Open
fix: allow code page to scroll naturally like docs page#363codecustard wants to merge 1 commit intocaffeinelabs:mainfrom
codecustard wants to merge 1 commit intocaffeinelabs:mainfrom
Conversation
- Remove max-height constraint on code view that was keeping it contained within viewport - Add scroll event listener alongside resize for dynamic panel adjustment - Change overflow from 'auto' to 'overflow-x' only - Add min-height to push footer below fold like other pages This makes the code page scroll behavior consistent with the docs page, allowing users to scroll the entire page to hide the hero/banner section.
4 tasks
Kamirus
added a commit
that referenced
this pull request
Mar 23, 2026
## Summary - Bumped `tar` (7.5.9 → 7.5.11) and `minimatch` (10.0.1 → 10.2.4) in `cli/package.json` — security fixes for path traversal and ReDoS - Updated `cli/package-lock.json` and `docs/package-lock.json` transitive deps in-place to pick up security patches (lodash, js-yaml, node-forge, jws, undici, flatted, ajv, etc.) - `cli-releases/frontend` changes come from merged PR #340 (vite 5.2.6 → 5.4.21) - `frontend/package-lock.json` reverted to main — `npm update --legacy-peer-deps` introduced a `@dfinity/agent` ↔ `@dfinity/candid` peer dep conflict that broke CI - `blog/package-lock.json` was already up to date (no changes needed) ### What was NOT included and why - **`frontend/package-lock.json`** — peer dep conflict between `@dfinity/agent@1.0.1` and `@dfinity/candid@0.19.3` prevents a clean lockfile update. Needs a coordinated `@dfinity/*` dependency bump in a separate PR. - **Unfixable transitive vulns in CLI** — `axios` (via `wasm-pack` → `binary-install`) and `esbuild` (via `tsx`) can't be updated without breaking upstream. Pre-existing on main. ### Closed dependabot PRs (replaced by this PR) #368, #341, #344, #338, #345, #346, #349, #323, #328, #382, #353, #359, #357, #348, #325, #324, #421, #419, #379, #377 ## Test plan - [x] Benchmarks pass - [x] mops test passes (node 20 + node 24, all install methods) - [ ] CI workflow passes - [ ] Code quality (lint, format) passes ## Verification Ran findings-verifier on both direct dependency bumps: - **minimatch 10.0.1 → 10.2.4**: All changes are additive (new options, perf/security hardening). CLI uses a simple glob pattern unaffected by any changes. - **tar 7.5.9 → 7.5.11**: Pure security fixes in extraction path validation. No API surface changes. CLI's tar usage (create + extract) is standard and unaffected. - **No new peer deps**, no engine requirement changes, no breaking API changes. --- ## Remaining Open PRs — TODO ### Review & Merge (real package.json bumps, security fixes) | PR | What | Status | |---|---|---| | #336 | Vite 5.2.6 → 5.4.21 in `/frontend` | Multiple CVEs fixed | | #361 | Elliptic + ic-mops in `/frontend` | Critical crypto vulnerability | | #367 | Tar + ic-mops in `/frontend` | Tar path traversal fix | | #420 | Devalue + @sveltejs/kit in `/cli-releases/frontend` | Real package.json bump | ### Need @dependabot rebase (merge conflict with main) | PR | What | Status | |---|---|---| | #372 | Tar 7.5.6 → 7.5.7 in `/cli` | Now superseded — tar bumped to 7.5.11 in this PR | | #342 | Glob 11.0.1 → 11.1.0 in `/cli` | Security fix — GHSA-5j98-mcp5-4vw2 | ### Need Careful Review (major version bumps, risk of breakage) | PR | What | Status | |---|---|---| | #380 | Docusaurus 2.4.3 → 3.9.2 in `/docs` | Major v2 → v3. Test docs locally. | | #329 | vite-plugin-static-copy 1.0.2 → 2.3.2 in `/frontend` | Major v1 → v2. Has security fix but API may differ. | ### Non-Dependabot PRs | PR | Author | What | |---|---|---| | #411 | rvanasa | Test global Mops installation in CI | | #363 | codecustard | Fix code page scroll naturally like docs page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the code page scroll behavior consistent with the docs page, allowing users to scroll the entire page to hide the hero/banner section.
BEFORE:
before.mov
AFTER: (test page, 8b3ef81)
Screen.Recording.2026-01-17.at.3.21.19.PM.mov