Conversation
|
Thanks! The only changes I'm unsure of were the ones to the readme. I'll annotate them. |
| Add Firedart to your `pubspec.yaml` file: | ||
|
|
||
| ``` yaml | ||
| ```yaml |
There was a problem hiding this comment.
Why change the format here? Was it automated?
There was a problem hiding this comment.
ah, yes sorry about that - I think some MD auto formatter in VSCode, my bad
There was a problem hiding this comment.
I figured, no worries don't waste time trying to fix this.
|
|
||
| To regenerate them, you will need to check out both [googleapis](https://github.com/googleapis/googleapis) and [protobuf](https://github.com/google/protobuf). | ||
|
|
||
| **SIDENOTE**: `protobuf` doesn't seem to be needed anymore, you can just use those via `import 'package:protobuf/well_known_types/google/protobuf/wrappers.pb.dart';` |
There was a problem hiding this comment.
If the protobuf dependency is no longer necessary can we remove it from pubspec.yaml?
In that case I would also remove this line from here since it doesn't impact library users, and add a note to the release notes.
There was a problem hiding this comment.
You don't need to check out protobuf repo anymore and generate dart classes from it. These classes seem to come now as a part of protobuf package under well_known_types. That said - you still need protobuf package in pubspec but it's one less repo to check out now.
There was a problem hiding this comment.
That makes sense. In any case I think we can leave this note out since it's not relevant for users of this library.
I'm happy to accept those changes as well if you're willing to commit them. |
2 participants
TL;DR: I've updated something that updated something that needed me to update this. Now it works for me. Maybe it can be merged and published as new version.
I can improve my PR if it there's any attention from the repo owner - no need to rush tho, we all have our priorities. Great package btw! I think the regen.sh script could be better, e.g. lock to version of the repo and also check it out on the fly in an ignored folder.