Skip to content

feat: let a Store carry a base engine that processor engines clone#144

Merged
cablehead merged 2 commits into
mainfrom
feat/engine-base
Jun 20, 2026
Merged

feat: let a Store carry a base engine that processor engines clone#144
cablehead merged 2 commits into
mainfrom
feat/engine-base

Conversation

@cablehead

@cablehead cablehead commented Jun 19, 2026

Copy link
Copy Markdown
Owner

What

Store::with_base_engine(EngineState) lets an embedder set a base engine the processors clone. prepared_base clones it (or the default Engine::new()), then layers the store commands. No base set: behaviour unchanged.

Why

prepared_base gave embedders nowhere to add commands, so http-nu's .mj never reached services or actors. EngineState is the shared type, so http-nu builds a base and hands it over.

Notes

  • Model: ADR 0007 (prepare a base once, clone per subsystem).
  • Test: src/nu/test_base_engine.rs. Suite green.
  • http-nu bug: src/nu/commands/append_command.rs :: input handling #48 builds on this.
  • check.sh clippy flags pre-existing result_large_err in untouched cat_stream_command.rs (stable 1.96 vs MSRV 1.93.1); CI's non-strict clippy is unaffected.

@cablehead cablehead force-pushed the feat/engine-base branch 4 times, most recently from 22f7b66 to 761cf65 Compare June 20, 2026 01:54
@cablehead cablehead merged commit 0a557ac into main Jun 20, 2026
10 checks passed
@cablehead cablehead deleted the feat/engine-base branch June 20, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant