feat: let a Store carry a base engine that processor engines clone#144
Merged
Conversation
22f7b66 to
761cf65
Compare
761cf65 to
47eeca2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Store::with_base_engine(EngineState)lets an embedder set a base engine the processors clone.prepared_baseclones it (or the defaultEngine::new()), then layers the store commands. No base set: behaviour unchanged.Why
prepared_basegave embedders nowhere to add commands, so http-nu's.mjnever reached services or actors.EngineStateis the shared type, so http-nu builds a base and hands it over.Notes
src/nu/test_base_engine.rs. Suite green.check.shclippy flags pre-existingresult_large_errin untouchedcat_stream_command.rs(stable 1.96 vs MSRV 1.93.1); CI's non-strict clippy is unaffected.