Fix oncoprint track alteration percentage to use as numerator the count of altered AND sequence items #5299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt of altered AND sequence items
…nt of altered AND sequence items
onursumer
approved these changes
Nov 19, 2025
Member
onursumer
left a comment
onursumer
left a comment
There was a problem hiding this comment.
LGTM! Just added a couple of minor suggestions
Comment on lines
+614
to
+619
| const alteredKeys = data.trackData!.reduce((acc, next) => { | ||
| if (isAltered(next)) { | ||
| acc.add(next.uid); | ||
| } | ||
| return acc; | ||
| }, new Set<string>()); |
Member
There was a problem hiding this comment.
Minor thing but I find it more readable when we do filter and map instead of reduce.
Suggested change
| const alteredKeys = data.trackData!.reduce((acc, next) => { | |
| if (isAltered(next)) { | |
| acc.add(next.uid); | |
| } | |
| return acc; | |
| }, new Set<string>()); | |
| const alteredKeys = new Set<string>(data.trackData!.filter(isAltered).map(d => d.uid)); |
Comment on lines
+647
to
+657
| const alteredEntities = sampleMode | ||
| ? _(data.cases.samples) | ||
| .entries() | ||
| .filter(e => !!e[1].length) | ||
| .map(e => e[0]) | ||
| .value() | ||
| : _(data.cases.patients) | ||
| .entries() | ||
| .filter(e => !!e[1].length) | ||
| .map(e => e[0]) | ||
| .value(); |
Member
There was a problem hiding this comment.
This way we would avoid the duplicate .entries().filter(...).map(...).value() part
Suggested change
| const alteredEntities = sampleMode | |
| ? _(data.cases.samples) | |
| .entries() | |
| .filter(e => !!e[1].length) | |
| .map(e => e[0]) | |
| .value() | |
| : _(data.cases.patients) | |
| .entries() | |
| .filter(e => !!e[1].length) | |
| .map(e => e[0]) | |
| .value(); | |
| const alteredEntities = _(sampleMode ? data.cases.samples : data.cases.patients) | |
| .entries() | |
| .filter(e => !!e[1].length) | |
| .map(e => e[0]) | |
| .value() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cBioPortal/cbioportal#11796