add oncokb patient report tab to patient view page #5284
Conversation
| const clinicalDataGroupedBySample = | ||
| patientViewPageStore.clinicalDataGroupedBySample.result; | ||
|
|
||
| const patientMetadata = new PatientMetadata(); |
There was a problem hiding this comment.
lets put this code in a utitility file somewhere and add some comments about what it does.
There was a problem hiding this comment.
i mean the whole contents of the this useEffect hook. be careful though to dereference data from the mobx promises before you pass them into this function
| const IFRAME_NAME = 'patient-report-iframe'; | ||
|
|
||
| const PatientReportTab = observer( | ||
| ({ patientViewPageStore }: IPatientReportTabProps) => { |
There was a problem hiding this comment.
you should type this using React.FunctionComponent generic
There was a problem hiding this comment.
Wondering if we want to do this since React does not recommend. It's a rather trivial change so I'm find with it if it helps maintain the style of the codebase, but wondering your thoughts on this: facebook/create-react-app#8177
|
|
||
| let hugoSymbol = ''; | ||
| let entrezGeneId = 0; | ||
| if ('gene' in alt) { |
There was a problem hiding this comment.
i believe that typescript will not check this. i.e. you could put 'banana' in alt. better of just doing
alt.gene
| @@ -0,0 +1,296 @@ | |||
| import { | |||
There was a problem hiding this comment.
@bprize15 this file could use some summary comments and testing. Claude would do very well helping to build add a few tests.
Describe changes proposed in this pull request:
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>to determine thatand notify them either through slack or by assigning them as a reviewer on the PR