Resource table improvement #5270
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dippindots
force-pushed
the
improve-resources-feature
branch
from
b4819eb to
22011aa
Compare
dippindots
force-pushed
the
improve-resources-feature
branch
2 times, most recently
from
491ff4e to
3bdfd19
Compare
- Study View page: make table searchable and downloadable - Patient View page: make table searchable and downloadable
…art pluralization - Study View: Added visual indicators (user icon for Patient View links, external link icon for new window links) to clarify navigation destinations - Dynamic column headers that adapt based on resource type (e.g., "Pathology Reports per Patient") - Patient View: Simplified table by removing URL/Description columns, added resource counter (e.g., "1 of 3") - Consistent pluralization of resource names across tabs, headers, and metadata
dippindots
force-pushed
the
improve-resources-feature
branch
from
3bdfd19 to
df4c5ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#11682
How to test:
localStorage.netlify = "deploy-preview-5270--cbioportalfrontend"in the browser console first and refresh the pageChanges Made
Study View - Files & Links Table
Added visual indicators for navigation clarity:
opens resource in Patient View
column - opens URL in new tab
Dynamic column naming: When all resources are the same type, "Resources per Patient"
column header changes to specific type (e.g., "Pathology Reports per Patient")
Consistent pluralization: Tab name and header always show plural form when single
resource type (e.g., "H&E Slides")
Show customized text for samples: Since now we only have one link per sample, so we need to change the text to better convey what do we have: e.g.
xx H&E Samples with SlidesHide Recources Per Patient column: For the same reason (we only have one link per sample), we should hide this column too
Patient View - Files & Links Table
Added user icon (fa-user) on resource name column to indicate it opens in Patient View
Added external link icon (fa-external-link) on "Resource URL" column for external links
Dynamic column naming: When all resources are the same type, column shows resource type
name instead of generic "Resource"
Smart tab name pluralization:
Patient View - Resource Viewer