Add mrna expression plots tab to patient page #5267
Conversation
gblaih
force-pushed
the
patient-expression-plots-tab
branch
from
c22fc2a to
afb7e33
Compare
| fillOpacity: number | ((d: D) => number), | ||
| symbol: string | ((d: D) => string), | ||
| zIndexSortBy?: ((d: D) => any)[] // second argument to _.sortBy | ||
| zIndexSortBy?: ((d: D) => any)[], // second argument to _.sortBy |
There was a problem hiding this comment.
see if you can filter these out of before you call this function and deal with them at a higher level so as not to pollute this function
| : self.props.urlWrapper.query.plots_horz_selection) || | ||
| {}; | ||
| const param = urlSelection.selectedGeneOption; | ||
| const localSelection = vertical |
There was a problem hiding this comment.
lets discuss this requirment with jj. if this is really important, we should have some systematic way of persistenting default settings. not just one off like htis
| ); | ||
| } | ||
|
|
||
| @action.bound |
There was a problem hiding this comment.
all this will hopefully be externalized
| this.horzGeneOptions | ||
| .isPending | ||
| } | ||
| defaultOptions={ |
There was a problem hiding this comment.
clean this up with a helper function
There was a problem hiding this comment.
lets push back on this. if it needs to work this way, we need to refactor
| export interface IBaseScatterPlotData { | ||
| x: number; | ||
| y: number; | ||
| sampleId: string; |
There was a problem hiding this comment.
same comment as above. try to not to corrupt this component
gblaih
force-pushed
the
patient-expression-plots-tab
branch
from
f8906a3 to
90fe3a3
Compare
2 participants
No description provided.