-
-
Notifications
You must be signed in to change notification settings - Fork 348
Add Variant Allele Frequency Heatmap in Oncoprint - GSoC'25 #5237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2fca052 to
b7ff269
Compare
onursumer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality looks good, thanks!
The code can be improved/simplified further. See the comments.
|
Hey @rishisulakhe - this is cool! I tried it, but ran into this issue, everything shows up blank:
|
|
Hi @inodb |
onursumer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. Requested a few more minor changes.
| profile.molecularAlterationType === | ||
| AlterationTypeConstants.MUTATION_EXTENDED | ||
| ) { | ||
| label = `Variant Allele Frequency`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding Variant Allele Frequency might be problematic in the future if we want to add a new mutation related track other than VAF. Not sure what's the best way to address this issue though.
|
@rishisulakhe Great work! Thank you! Did some product testing: Bug 1For This URL
Maybe don't show VAF as an option in the heatmap when there is no allele frequency available for any of the samples? Bug 2Ensure the VAF heatmap reflects OQL, i.e. the EGFR MUT=L858R filter should be applied to the VAF Heatmap track too:
Bug 3Profiled but EGFR mutation not detected should be white (the line should only show up for the "not profiled" cases, same as for regular mutations track):
|
|
Hi @inodb @onursumer
Done✅. Now we are not showing VAF in heatmap option when no VAF data is available for any sample.
Still working on it.
Done✅. Now we are showing light grey color for samples with profiled but not mutated. Here is demo Also we have one more bug from product team, still need to be address. Like we add clinical track(cancer type) and click on show gaps with %, then add VAF or any heatmap results showing incorrect rendering of genetic track. |
|
Cool. One comment: The cluster function does not seem to work. cluster example for expression |
|
This is awesome! A few things I noticed:
Let's call the OncoPrint section 'Variant Allele Frequency' instead of 'Mutations'
|
|
Great points, Tali. @rishisulakhe For point 3, I think it'd be great if we can have a toggle in the VAF heatmap section to let the user decide whether the VAF heatmap should only display VAFs for the mutations shown in OncoPrint above. |
|
In the menu dropdown, maybe change "Variant Allele Frequency" to "Variant Allele Frequency in Selected Mutations Profile" |
bb73835 to
c7063b3
Compare







Registered "Variant Allele Frequency" as a new type of molecular profile heatmap that the OncoPrint can display. This allowed it to appear as a selectable option in the "Heatmap" of "Track" menu alongside existing heatmaps.
Screen.Recording.2025-11-12.232916.mp4
Preview link: https://deploy-preview-5237.preview.cbioportal.org/