Align heatmap RNASeq scores with oncoprint tracks #11592 #5225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inodb
approved these changes
Aug 13, 2025
Member
There was a problem hiding this comment.
Thanks! This def looks better!
Some comment in the description as well how the aggregation logic would be good. Also ideally both tracks should use the same functions for the aggregation logic, I didn't confirm in code if that's how it works
Note that selecting the patient level aggregation logic for RNASeq is a bit more complex than for mutation data (union), but this seems reasonable (if an expression query with threshold exists -> pick thresholded samples absolute max value)
alisman
reviewed
Aug 14, 2025
| query | ||
| )!.data!; | ||
|
|
||
| // get Z-score threshold from the store (default to 2 if not present) |
Collaborator
There was a problem hiding this comment.
can you see if there is a constand somewhere for default 2?
alisman
reviewed
Aug 14, 2025
| default: | ||
| bestValue = _.maxBy(dataWithValue, (d: HeatmapCaseDatum) => | ||
| Math.abs(d.value) | ||
|
|
Collaborator
There was a problem hiding this comment.
would be good to have a unit test for this. let me know if you need help setting that up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix frontend ticket #11592
Note: left original logic as fallback in DataUtils.ts