FEATURE: [indicator] Add VWAP indicator#1258
Open
austin362667 wants to merge 6460 commits intoc9s:mainfrom
Open
FEATURE: [indicator] Add VWAP indicator#1258austin362667 wants to merge 6460 commits intoc9s:mainfrom
austin362667 wants to merge 6460 commits intoc9s:mainfrom
Conversation
…r-mm FEATURE: add risk controls for strategies
FIX: [grid2] use tryLock during the openGrid process
FEATURE: add v2 indicator set api
REFACTOR: [bollmaker] upgrade to indicator v2
…ders pkg/exchange: add QueryOpenOrders API for bybit
FEATURE: [bybit] support place order
FEATURE: [bybit] support cancel order
…-query-closed-order FIX: [max] return err on max queryClosedOrdersByLastOrderID
FEATURE: [bybit] query closed order
FEATURE: [max] add fee_discounted to Trade struct for RESTful api
…-end-time FIX: fix batch query trade missing time range
merge back v1.50 into main
|
Welcome back! @austin362667, This pull request may get 257 BBG. |
c9s
reviewed
Jul 31, 2023
| return s | ||
| } | ||
|
|
||
| func (s *VWAPStream) calculate() float64 { |
Owner
There was a problem hiding this comment.
You need to check both the rawCloseValues, rawVolumeValues length, because it could trigger twice since you have 2 update callbacks, or you can subscribe the KLine stream
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2