feat(sdk): implement FirewallNode and FirewallCallbackHandler adapters#29
Open
thesamedorcas wants to merge 2 commits into
Open
feat(sdk): implement FirewallNode and FirewallCallbackHandler adapters#29thesamedorcas wants to merge 2 commits into
thesamedorcas wants to merge 2 commits into
Conversation
tharindupr
requested changes
Mar 31, 2026
tharindupr
left a comment
tharindupr
left a comment
Collaborator
There was a problem hiding this comment.
Where are the tests?
Author
@tharindupr Tests are next. I wanted to get the initial implementation up before the proposal deadline. I've been working on them, I'll try to push soon |
Author
@tharindupr Tests pushed: 15 passing across both adapters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the two framework adapter stubs.
FirewallNode (langgraph.py): wraps a Firewall instance as a LangGraph node. Intercepts agent state at message ingress (on_prompt) and before RAG injection (on_context). Raises NodeInterrupt on BLOCK decisions. Handles both plain string messages and LangChain message objects.
FirewallCallbackHandler (langchain.py): hooks into LangChain's callback system via on_tool_start and on_llm_start. Raises ToolException on BLOCK decisions. Works with any LangChain chain or agent without structural changes.
Tests and example agents to follow.