fix(hmac): enforce key length#22
Open
AndyVale wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specs specify 32-byte keys for the HMAC. However, the code was only checking for non-empty keys, effectively accepting keys with a minimum length of 1 byte.
In normal conditions, a user would use a reasonably strong key, but since the check is trivial to add, I think it is worth explicitly validating the length of the provided key.
Without this check, an attacker who is somehow able to determine the length of the key could also brute-force it, completely compromising the system.
With this modification, the minimum key length is 32 bytes, as the other files suggest.
I also added a very simple unit test to check the error.