Support container metric collection for Quadlets (Podman via Systemd)#38
Open
plexus wants to merge 1 commit into
Open
Support container metric collection for Quadlets (Podman via Systemd)#38plexus wants to merge 1 commit into
plexus wants to merge 1 commit into
Conversation
When running as quadlet, the cgroup directory uses a different naming format than plain libpod/podman. Instead, resolve the cgroup path via `/proc/<pid>/cgroup`. The container PID was already resolved via a docker inspect call in `readNetIO`, this has been hoisted into a separate `containerPid` function. The fallback case where no socket/API is available has been amended as well to scan for quadlet-style paths (cgroup/system.slice/<unit>.service/libpod-payload-<id>).
Author
|
CI was failing over a linting issue, I pushed a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running as quadlet, the cgroup directory uses a different naming format than plain libpod/podman. Instead, resolve the cgroup path via
/proc/<pid>/cgroup. The container PID was already resolved via a docker inspect call inreadNetIO, this has been hoisted into a separatecontainerPidfunction.Podman actually exposes the cgroup directory directly in the API, but docker does not, which is why I went with this approach.
The fallback case where no socket/API is available has been amended as well to scan for quadlet-style
paths (cgroup/system.slice/.service/libpod-payload-).
This was written with the help of Deepseek V4 Pro. I tried to keep it minimal. I diagnosed the issue myself first, and I reviewed and tested the code afterwards.