Skip to content

initial preset for imbs-mt #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
netbrain wants to merge 3 commits into
base: master
Choose a base branch
from
Open

initial preset for imbs-mt #793

netbrain wants to merge 3 commits into from

Conversation

@netbrain
Copy link

@netbrain netbrain commented Sep 25, 2019

No description provided.

@saudet
Copy link
Member

saudet commented Oct 2, 2019

This looks good in general, but it's missing some sample code in the README.md file and in the samples subdirectory, so I can't test it. Could you add something there?

Could you also try to replace all the values in @Platform(inherit = ...) with just opencv_features2d.class? That seems to work fine here, but again, I don't have anything to test it. What error messages are you getting if you do that?

And please update your fork to OpenCV 4.1.1! We'll need to do that before we can merge. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement help wanted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@netbrain @saudet