feat: Add byted viking search knowledgebase skill#227
Conversation
marchpure
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 315c055618
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if not args.resource_id and not args.name: | ||
| raise SystemExit("info action requires --resource-id or --name") |
There was a problem hiding this comment.
When the task is to list available knowledge bases or route an otherwise topic-less request, SKILL.md tells the agent to use info to list metadata for the configured collections, and the script even has _fetch_collections_info() for that purpose. However, this guard exits unless a single --resource-id or --name is supplied, so python scripts/viking_search.py --action info can never enumerate DATABASE_VIKING_COLLECTION; those documented flows always fail before any allowed collection info is fetched.
Useful? React with 👍 / 👎.
2 participants
What changed
Added
skills/byted-viking-search-knowledgebasefromcode.byted.org/ai-search-rec/aisearch-arkclaworigin/master.The new skill includes:
SKILL.mdscripts/viking_search.pyand package markerVerification
diff -qr.aisearch-arkclaw:origin/master:skills/byted-viking-search-knowledgebase/*for all 5 files.skills/byted-viking-knowledgebaseonagentkit-samples/main; it is not the same code or structure, so this PR adds the source skill under its original name instead of replacing the existing skill.python3 -m py_compile skills/byted-viking-search-knowledgebase/scripts/viking_search.py.Notes
git diff --checkreports trailing whitespace and EOF blank-line issues inside the copied API reference markdown. Those are preserved intentionally so the submitted skill remains byte-for-byte equivalent to the source.