Allow marking data objects as used for the linker #11206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
commented
Jul 9, 2025
cranelift/object/src/backend.rs
Outdated
| _ => unreachable!(), | ||
| } | ||
| } | ||
| object::BinaryFormat::Coff => {}, |
There was a problem hiding this comment.
I couldn't find what flag is necessary for Windows (if any).
|
Also could this get a backport to the branch for the next Cranelift release. rust-lang/rust#140525 has removed a workaround for |
github-actions
bot
added
cranelift
abrown
approved these changes
Jul 10, 2025
bjorn3
commented
Jul 10, 2025
| match &mut section.flags { | ||
| SectionFlags::None => { | ||
| section.flags = SectionFlags::Elf { | ||
| sh_flags: object::elf::SHF_GNU_RETAIN.into(), |
There was a problem hiding this comment.
This should have also included elf::SHF_ALLOC | elf::SHF_WRITE (or elf::SHF_ALLOC only when the data object is neither writable nor contains relocations).
bjorn3
commented
Jul 10, 2025
| let symbol = self.object.symbol_mut(symbol); | ||
| assert!(matches!(symbol.flags, SymbolFlags::None)); | ||
| symbol.flags = SymbolFlags::MachO { | ||
| n_desc: object::macho::N_NO_DEAD_STRIP, |
There was a problem hiding this comment.
And I think this is missing N_WEAK_REF/N_WEAK_DEF for weak symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10758